[Dashboard] Turn on new dashboard by default pt 2 #11510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files are not included in the wheel yet the dashboard modules include test files within the module. This commit makes those test files only import conftest and other testing files if being run as main.
…lter for test_ files in setup.py
… fix windows incompatibility issues.
… command to fetch a docker image that is timing out (I think)
… where it might be failing
…kend needs to be able to start running in order to provide the reporter in the new dash architecture, so we need to make sure this works.
6 tasks
6 tasks
edoakes
approved these changes
Oct 23, 2020
| @@ -30,7 +30,7 @@ | |||
|
|
|||
| def setup_static_dir(): | |||
| build_dir = os.path.join( | |||
| os.path.dirname(os.path.abspath(__file__)), "client/build") | |||
| os.path.dirname(os.path.abspath(__file__)), "client", "build") | |||
There was a problem hiding this comment.
is this an intentional change?
edoakes
reviewed
Oct 23, 2020
| @@ -304,7 +302,7 @@ async def _check_parent(): | |||
| args.redis_address, password=args.redis_password) | |||
| traceback_str = ray.utils.format_error_message(traceback.format_exc()) | |||
| message = ("The agent on node {} failed with the following " | |||
| "error:\n{}".format(os.uname()[1], traceback_str)) | |||
| "error:\n{}".format(platform.uname()[1], traceback_str)) | |||
There was a problem hiding this comment.
can we just use socket.gethostname here instead? I think that's what we use in other places in the code
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
I reverted the previous roll-out due to bad wheel builds + windows errors. This is the next attempt.
Related issue number
Checks
scripts/format.shto lint the changes in this PR.