Skip to content

Commit 579c42f

Browse files
committed
better comment
Signed-off-by: Linkun Chen <github@lkchen.net>
1 parent ebc4b15 commit 579c42f

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

python/ray/llm/_internal/serve/deployments/llm/vllm/vllm_engine.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -315,10 +315,11 @@ async def _start_engine(self) -> "EngineClient":
315315
# 2. If VLLM_USE_V1 is set to 1, then it will use v1 engine even with
316316
# experimental features (such as launching vLLM on a non-main thread).
317317
# 3. If VLLM_USE_V1 is set to 0, force using v0 engine.
318+
# In Ray Serve LLM, we forbid case 1 because we have to know exactly which engine is used.
318319
if not envs.is_set("VLLM_USE_V1"):
319320
raise AssertionError(
320-
"Starting ray 2.45, VLLM_USE_V1 environmetn variable must be set "
321-
"to prevent undetermined behavior"
321+
"Starting from Ray 2.45, VLLM_USE_V1 environment variable must be "
322+
"set to prevent undetermined behavior"
322323
)
323324
if not envs.VLLM_USE_V1:
324325
return await self._start_engine_v0()

0 commit comments

Comments
 (0)