Skip to content

Commit

Permalink
fix some bug
Browse files Browse the repository at this point in the history
  • Loading branch information
Alisahhh committed Jul 22, 2020
1 parent 497f354 commit 34fecd1
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ matrix:
- TESTSUITE=streaming
- JDK='Oracle JDK 8'
- RAY_INSTALL_JAVA=1
- RAY_GCS_ACTOR_SERVICE_ENABLED=true\
- RAY_GCS_ACTOR_SERVICE_ENABLED=true
- PYTHON=3.6 PYTHONWARNINGS=ignore
- RAY_USE_RANDOM_PORTS=1
install:
Expand Down
1 change: 0 additions & 1 deletion src/ray/gcs/gcs_client/service_based_accessor.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1415,6 +1415,5 @@ Status ServiceBasedPlacementGroupInfoAccessor::AsyncCreatePlacementGroup(
return Status::OK();
}


} // namespace gcs
} // namespace ray
2 changes: 1 addition & 1 deletion src/ray/gcs/gcs_server/gcs_server.cc
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ void GcsServer::InitGcsJobManager() {
});
}

void GcsServer::InitGcsPlacementGroupManager() {
void GcsServer::InitGcsPlacementGroupManager() {
RAY_CHECK(gcs_table_storage_ != nullptr && gcs_node_manager_ != nullptr);
auto scheduler = std::make_shared<GcsPlacementGroupScheduler>(
main_service_, gcs_table_storage_, *gcs_node_manager_,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,6 @@ class GcsPlacementGroupSchedulerTest : public ::testing::Test {
std::shared_ptr<GcsServerMocker::MockGcsPubSub> gcs_pub_sub_;
std::shared_ptr<gcs::GcsTableStorage> gcs_table_storage_;
std::shared_ptr<gcs::RedisClient> redis_client_;

// /*schedule_failure_handler=*/

// /*schedule_success_handler=*/
// [this](std::shared_ptr<gcs::GcsPlacementGroup> placement_group) {
// success_placement_groups_.emplace_back(std::move(placement_group));
// },
};

TEST_F(GcsPlacementGroupSchedulerTest, TestScheduleFailedWithZeroNode) {
Expand Down

0 comments on commit 34fecd1

Please sign in to comment.