This repository was archived by the owner on Dec 11, 2021. It is now read-only.
Mark in_isr as unused in osal_pico.h
#12
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, there are a few other places that have the same issue. I will fix them all and amend the commit |
|
At some point in the near future we'll be switching to use upstream version of tinyusb (see raspberrypi/pico-sdk#321 ), so any PRs should probably be made to the upstream repo, https://github.com/hathach/tinyusb. |
This is the way unused parameters are dealt with in the rest of the
tinyusb codebase. It prevents the following warning when building
with -Wextra:
```C
In file included from [redacted]/pico-sdk/lib/tinyusb/src/osal/osal.h:57,
from [redacted]/pico-sdk/lib/tinyusb/src/tusb.h:38,
from [redacted]/pico-sdk/lib/tinyusb/src/device/usbd.c:31:
[redacted]/pico-sdk/lib/tinyusb/src/osal/osal_pico.h: In function 'osal_semaphore_post':
[redacted]/pico-sdk/lib/tinyusb/src/osal/osal_pico.h:60:71: error: unused parameter 'in_isr' [-Werror=unused-parameter]
60 | static inline bool osal_semaphore_post(osal_semaphore_t sem_hdl, bool in_isr)
| ^
In file included from [redacted]/pico-sdk/lib/tinyusb/src/osal/osal.h:57,
from [redacted]/pico-sdk/lib/tinyusb/src/tusb.h:38,
from [redacted]/pico-sdk/lib/tinyusb/src/device/usbd.c:31:
[redacted]/pico-sdk/lib/tinyusb/src/osal/osal_pico.h: In function 'osal_queue_send':
[redacted]/pico-sdk/lib/tinyusb/src/osal/osal_pico.h:162:79: error: unused parameter 'in_isr' [-Werror=unused-parameter]
162 | static inline bool osal_queue_send(osal_queue_t qhdl, void const * data, bool in_isr)
|
```
jonathangjertsen
force-pushed
the
mark_in_isr_as_unused
branch
from
30f1930 to
ad378bd
Compare
|
OK. I can't get my application to compile with the upstream tinyusb, so I'll hold off until the switch is complete. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the following warning when building with -Wextra:
Casting unused arguments to
voidis how unused parameters are dealt with in the rest of the tinyusb codebase