Skip to content
This repository was archived by the owner on Dec 11, 2021. It is now read-only.

usbd ack SET_INTERFACE if it is not implemented by class driver. #10

Closed
wants to merge 1 commit into from
Closed

usbd ack SET_INTERFACE if it is not implemented by class driver. #10

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented May 6, 2021

Describe the PR
This pull request solves a problem with WebUSB on Linux and probably also Mac OS. Without this patch trying to use WebUSB ends in error messages "NetworkError: Unable to set device interface."

This patch is not from me (correct author has been added) and originates from: hathach/tinyusb#711

I've tested the patch and with it applied, I can use the RPi Pico with WebUSB on Linux.

@lurch
Copy link

lurch commented May 6, 2021

Is this fix already included in tinyusb 0.9.0 ? See raspberrypi/pico-sdk#321

@ghost
Copy link
Author

ghost commented May 7, 2021

It is. So it depends on when you want to merge the new version. If it takes longer it may be helpful if you merge this smaller change in the mean time.

@lurch
Copy link

lurch commented May 8, 2021

That's entirely a @kilograham decision.

@kilograham
Copy link
Contributor

i mean i could merge it, but the sdk tinyusb submodule ref isn't going to get bumped until the next release which will pick up 0.9.0 anyway. It should be in under 2 weeks

@lurch
Copy link

lurch commented Jun 4, 2021

I guess this can be closed, now that 0.10.1 has been merged in?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upstream wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants