fix #if in hardware/structs/dma.h #9
Conversation
Defined here: https://github.com/raspberrypi/pico-sdk/blob/master/src/common/pico_base/include/pico/assert.h#L32 |
|
In that case, let me suggest a different approach. I’ve updated the PR to move these inline functions from: ./src/rp2040/hardware_structs/include/hardware/structs/dma.h which is a register definition include file where they seem out of place to: ./src/rp2_common/hardware_dma/include/hardware/dma.h where they are right are home with the DMA driver code that uses them. |
There was a problem hiding this comment.
Yes this is really where they belong, thanks
Not 100% sure why they were there to begin with - perhaps historical. Worth checking it doesn't break compilation of pico-examples, pico-extras, pico-playground (we're currently working on getting our CI re-setup after our move of everything to public github)
* fix #if in hardware/structs/dma.h * move dma driver code from register definitions to dma drivers Co-authored-by: Peter Lawrence <12226419+majbthrd@users.noreply.github.com>
I suspect the user's intent was to use "PARAM_ASSERTIONS_ENABLED_DMA" (default setting generated on lines 17-18).