add new M33 processor exception handlers #2482
Open
+30
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #2479 |
lurch
reviewed
May 22, 2025
Comment on lines
+55
to
+65
| #if PICO_RP2040 | ||
| .word isr_invalid // Reserved, should never fire | ||
| .word isr_invalid // Reserved, should never fire | ||
| .word isr_invalid // Reserved, should never fire | ||
| .word isr_invalid // Reserved, should never fire | ||
| #else | ||
| .word isr_memmanage | ||
| .word isr_busfault | ||
| .word isr_usagefault | ||
| .word isr_securefault | ||
| #endif |
There was a problem hiding this comment.
Minor nitpick, but it kinda feels like isr_memmanage is a "specific" action, and isr_invalid is a "default" action, so I wonder if it might make more sense to write this as:
#if PICO_RP2350
.word isr_memmanage
.word isr_busfault
.word isr_usagefault
.word isr_securefault
#else
.word isr_invalid // Reserved, should never fire
.word isr_invalid // Reserved, should never fire
.word isr_invalid // Reserved, should never fire
.word isr_invalid // Reserved, should never fire
#endif? 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.