Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CYW43 support only if PICO_BOARD=pico_w #979

Open
Memotech-Bill opened this issue Aug 18, 2022 · 2 comments
Open

CYW43 support only if PICO_BOARD=pico_w #979

Memotech-Bill opened this issue Aug 18, 2022 · 2 comments
Assignees
Labels
Milestone

Comments

@Memotech-Bill
Copy link

The various CMake link library options pico_cyw43_arch_... only have any affect if the CMake call defines PICO_BOARD=pico_w. Otherwise they default to no-op.

This causes problems if (for example) the Pico W is plugged into a VGA Demo Board. Creating a vgaboard_w.h file, which is a copy of vgaboard.h, but with the #include "boards/pico.h" replaced by #include "boards/pico_w.h" does not resolve the problem.

The simplest work around I have found is to include the following very early in the CMake file:

set(PICO_CYW43_SUPPORTED 1)

I have yet to work out whether this needs to be above pico_sdk_init() or above include(pico_sdk_import.cmake).

@kilograham kilograham added this to the 1.6.0 milestone May 26, 2023
@kilograham kilograham self-assigned this May 26, 2023
@erdometo
Copy link

erdometo commented Jun 5, 2023

If you are building from command line, no problem. But VSCode uses its own cmake extension to lint errors. That extension has no setting to pass extra arguments. Only fix is set(PICO_CYW43_SUPPORTED 1) in cmakelists.txt.

@kilograham kilograham modified the milestones: 1.6.1, 1.6.2 Jul 19, 2024
@kilograham kilograham modified the milestones: 1.6.2, 2.0.0, 2.1.0 Aug 8, 2024
@kilograham
Copy link
Contributor

We plan to add a PICO_CARRIER_BOARD or similar in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants