New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NULL pointer dereference in scanvideo_begin_scanline_generation #17

Open

Memotech-Bill opened this issue Apr 9, 2021 · 2 comments

Memotech-Bill commented Apr 9, 2021 •

edited

Loading

If:

routine scanvideo_begin_scanline_generation is called with block = false,
there are no available buffers on shared_state.free_list.free_list
and PICO_SCANVIDEO_LINKED_SCANLINE_BUFFERS is true

then at line 1092 of scanvideo,c:

the variable fsb is NULL
and is dereferenced.

This line should probably be moved up to line 1081.

Contributor

kilograham commented Apr 10, 2021

ha, yes i've definitely never tried that :-)

Author

Memotech-Bill commented Apr 10, 2021

I haven't tried it either :)

I don't even know what PICO_SCANVIDEO_LINKED_SCANLINE_BUFFERS is for. I am just reading through the code, trying to understand it, and spotted that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment