Skip to content

Commit a4c253d

Browse files
Marek Vasutrobertfoss
authored andcommitted
drm/bridge: tc358764: Use BIT() macro for actual bits
None of these four bits are bitfields, use BIT() macro and treat them as bits. No functional change. Signed-off-by: Marek Vasut <marex@denx.de> Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Signed-off-by: Robert Foss <rfoss@kernel.org> Link: https://patchwork.freedesktop.org/patch/msgid/20230615201635.565973-1-marex@denx.de
1 parent 21aa27d commit a4c253d

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

drivers/gpu/drm/bridge/tc358764.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -42,10 +42,10 @@
4242

4343
/* Video path registers */
4444
#define VP_CTRL 0x0450 /* Video Path Control */
45-
#define VP_CTRL_MSF(v) FLD_VAL(v, 0, 0) /* Magic square in RGB666 */
46-
#define VP_CTRL_VTGEN(v) FLD_VAL(v, 4, 4) /* Use chip clock for timing */
47-
#define VP_CTRL_EVTMODE(v) FLD_VAL(v, 5, 5) /* Event mode */
48-
#define VP_CTRL_RGB888(v) FLD_VAL(v, 8, 8) /* RGB888 mode */
45+
#define VP_CTRL_MSF BIT(0) /* Magic square in RGB666 */
46+
#define VP_CTRL_VTGEN BIT(4) /* Use chip clock for timing */
47+
#define VP_CTRL_EVTMODE BIT(5) /* Event mode */
48+
#define VP_CTRL_RGB888 BIT(8) /* RGB888 mode */
4949
#define VP_CTRL_VSDELAY(v) FLD_VAL(v, 31, 20) /* VSYNC delay */
5050
#define VP_CTRL_HSPOL BIT(17) /* Polarity of HSYNC signal */
5151
#define VP_CTRL_DEPOL BIT(18) /* Polarity of DE signal */
@@ -233,8 +233,8 @@ static int tc358764_init(struct tc358764 *ctx)
233233
tc358764_write(ctx, DSI_STARTDSI, DSI_RX_START);
234234

235235
/* configure video path */
236-
tc358764_write(ctx, VP_CTRL, VP_CTRL_VSDELAY(15) | VP_CTRL_RGB888(1) |
237-
VP_CTRL_EVTMODE(1) | VP_CTRL_HSPOL | VP_CTRL_VSPOL);
236+
tc358764_write(ctx, VP_CTRL, VP_CTRL_VSDELAY(15) | VP_CTRL_RGB888 |
237+
VP_CTRL_EVTMODE | VP_CTRL_HSPOL | VP_CTRL_VSPOL);
238238

239239
/* reset PHY */
240240
tc358764_write(ctx, LV_PHY0, LV_PHY0_RST(1) |

0 commit comments

Comments
 (0)