Skip to content

Commit 3294d29

Browse files
committed
drm/panel-simple: Remove custom handling of orientation
The framework now handles reading orientation from DT, therefore remove the custom get_orientation hook from panel-simple. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
1 parent 5666327 commit 3294d29

File tree

1 file changed

+0
-22
lines changed

1 file changed

+0
-22
lines changed

drivers/gpu/drm/panel/panel-simple.c

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,6 @@ struct panel_simple {
154154
struct edid *edid;
155155

156156
struct drm_display_mode override_mode;
157-
158-
enum drm_panel_orientation orientation;
159157
};
160158

161159
static inline struct panel_simple *to_panel_simple(struct drm_panel *panel)
@@ -412,12 +410,6 @@ static int panel_simple_get_modes(struct drm_panel *panel,
412410
/* add hard-coded panel modes */
413411
num += panel_simple_get_non_edid_modes(p, connector);
414412

415-
/*
416-
* TODO: Remove once all drm drivers call
417-
* drm_connector_set_orientation_from_panel()
418-
*/
419-
drm_connector_set_panel_orientation(connector, p->orientation);
420-
421413
return num;
422414
}
423415

@@ -438,20 +430,12 @@ static int panel_simple_get_timings(struct drm_panel *panel,
438430
return p->desc->num_timings;
439431
}
440432

441-
static enum drm_panel_orientation panel_simple_get_orientation(struct drm_panel *panel)
442-
{
443-
struct panel_simple *p = to_panel_simple(panel);
444-
445-
return p->orientation;
446-
}
447-
448433
static const struct drm_panel_funcs panel_simple_funcs = {
449434
.disable = panel_simple_disable,
450435
.unprepare = panel_simple_unprepare,
451436
.prepare = panel_simple_prepare,
452437
.enable = panel_simple_enable,
453438
.get_modes = panel_simple_get_modes,
454-
.get_orientation = panel_simple_get_orientation,
455439
.get_timings = panel_simple_get_timings,
456440
};
457441

@@ -579,12 +563,6 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc)
579563
return dev_err_probe(dev, PTR_ERR(panel->enable_gpio),
580564
"failed to request GPIO\n");
581565

582-
err = of_drm_get_panel_orientation(dev->of_node, &panel->orientation);
583-
if (err) {
584-
dev_err(dev, "%pOF: failed to get orientation %d\n", dev->of_node, err);
585-
return err;
586-
}
587-
588566
ddc = of_parse_phandle(dev->of_node, "ddc-i2c-bus", 0);
589567
if (ddc) {
590568
panel->ddc = of_find_i2c_adapter_by_node(ddc);

0 commit comments

Comments
 (0)