-
-
Notifications
You must be signed in to change notification settings - Fork 0
New: Rework release mechanics to allow other types of releases #461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 25 out of 40 changed files in this pull request and generated 4 comments.
Files not reviewed (15)
- Source/Bake.Tests/Files/nuget-config.xml: Language not supported
- Source/Bake/Cooking/Cooks/.gitignore: Language not supported
- Source/Bake/Context.cs: Evaluated as low risk
- Source/Bake/Cooking/Cooks/OctopusDeploy/OctopusDeployPackagePushCook.cs: Evaluated as low risk
- Source/Bake/Cooking/Ingredients/Gathers/DynamicDestinationGather.cs: Evaluated as low risk
- Source/Bake.Tests/ExplicitTests/GitHubReleaseCookTests.cs: Evaluated as low risk
- Source/Bake.Tests/Helpers/TestFor.cs: Evaluated as low risk
- Source/Bake.Tests/Helpers/TestProject.cs: Evaluated as low risk
- Source/Bake.Tests/Helpers/TestIt.cs: Evaluated as low risk
- Source/Bake/Core/File.cs: Evaluated as low risk
- Source/Bake.Tests/Helpers/BakeTest.cs: Evaluated as low risk
- Source/Bake.Tests/UnitTests/Services/ComposerOrderingTests.cs: Evaluated as low risk
- Source/Bake/Cooking/Cooks/GitHub/GitHubReleaseCook.cs: Evaluated as low risk
- Source/Bake/Core/Defaults.cs: Evaluated as low risk
- Source/Bake/Cooking/Composers/GitHubReleaseComposer.cs: Evaluated as low risk
Comments suppressed due to low confidence (6)
Source/Bake.Tests/UnitTests/Cooking/Cooks/ReleaseCookTests.cs:66
- Invalid array initialization syntax. Use
new[] { NewReleaseFile() }for array initializations.
[NewReleaseFile()])
Source/Bake.Tests/UnitTests/Cooking/Cooks/ReleaseCookTests.cs:86
- Invalid array initialization syntax. Use
new[] { NewReleaseDirectory() }for array initializations.
[NewReleaseDirectory()])
Source/Bake.Tests/UnitTests/Cooking/Cooks/ReleaseCookTests.cs:106
- Invalid array initialization syntax. Use
new[] { NewMixedRelease(), NewReleaseDirectory(), NewReleaseFile() }for array initializations.
[NewMixedRelease(), NewReleaseDirectory(), NewReleaseFile()])
Source/Bake.Tests/UnitTests/Cooking/Cooks/ReleaseCookTests.cs:154
- Invalid array initialization syntax. Use
Enumerable.Range(0, fileCount).Select(_ => NewFile()).ToArray()for array initializations.
Enumerable.Range(0, fileCount).Select(_ => NewFile()).ToArray()
Source/Bake/Cooking/Composers/ReleaseComposer.cs:47
- The architecture name 'x64' is inconsistent with common naming conventions. It should be 'x86_64'.
[ExecutableArchitecture.Intel64] = "x64",
Source/Bake/Cooking/Composers/ReleaseComposer.cs:165
- Ensure that the paths are unique before concatenating them to prevent potential duplication issues.
return Enumerable.Empty<string>()
Remember