Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ner_features by text_dense_features #4957

Closed
tabergma opened this issue Dec 12, 2019 · 0 comments · Fixed by #4935
Closed

Replace ner_features by text_dense_features #4957

tabergma opened this issue Dec 12, 2019 · 0 comments · Fixed by #4935
Assignees
Labels
type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@tabergma
Copy link
Contributor

If you wanted to use additional features in the CRFEntityExtractor you had to add ner_features to the feature list of the entity extractor. Additionally, you need a featurizer that actually sets those features. The main difference of those features are, that they should come as a sequence.

With the upcoming changes it will be possible to easily define for every featruizer whether it should return its features as sequence or not. Also, we are planning to add more featurizers that return embeddings from pre-trained language models.

To be able to easily make use of any of those features, we should exchange the logic of ner_features. You should be able to use the features any featurizer, that returns word embeddings, in the CRFEntityExtractor. Those features will be stored in the attribute text_dense_features of the message. The featurizer needs to return a sequence of features. Otherwise, the features cannot be used and a warning should be printed.

@tabergma tabergma added the type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR label Dec 12, 2019
@tabergma tabergma self-assigned this Dec 12, 2019
@tabergma tabergma mentioned this issue Dec 12, 2019
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant