Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate LivewireComponentColumn methods and add some missing basic tests #2168

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Jan 11, 2025

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

Attention: Patch coverage is 35.71429% with 18 lines in your changes missing coverage. Please review.

Project coverage is 91.02%. Comparing base (2ecd092) to head (f7d0b59).

Files with missing lines Patch % Lines
.../Traits/Helpers/LivewireComponentColumnHelpers.php 28.00% 18 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             development    #2168      +/-   ##
=================================================
+ Coverage          90.92%   91.02%   +0.10%     
- Complexity          1988     1991       +3     
=================================================
  Files                211      212       +1     
  Lines               4494     4500       +6     
=================================================
+ Hits                4086     4096      +10     
+ Misses               408      404       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe merged commit 1d83e0e into rappasoft:development Jan 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant