Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH Fixes - Clean-up, efficiency, and Sort Icons fixes #2140

Merged
merged 8 commits into from
Dec 31, 2024

Conversation

lrljoe
Copy link
Collaborator

@lrljoe lrljoe commented Dec 31, 2024

Fixes to smooth the Sort Icon Styling approach

  • Tidy up main "th" blade - clean up class merging, reduce duplicated code

  • TH Bulk Actions - Clean up classes

  • TH Collapsing Columns - use Computed Properties, clean up classes

  • TH Label (new) - centralise the TH label

  • TH Plain - clean up classes

  • TH Reorder - clean up classes

  • TH Sort Icons - clean up classes, improve performance

  • Datatable - clean up attribute assignment

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests and did you add any new tests needed for your feature?
  2. Did you update all templates (if applicable)?
  3. Did you add the relevant documentation (if applicable)?
  4. Did you test locally to make sure your feature works as intended?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.53%. Comparing base (eda4c5e) to head (7becf76).

Additional details and impacted files
@@              Coverage Diff               @@
##             development    #2140   +/-   ##
==============================================
  Coverage          90.53%   90.53%           
  Complexity          1980     1980           
==============================================
  Files                205      205           
  Lines               4488     4488           
==============================================
  Hits                4063     4063           
  Misses               425      425           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrljoe lrljoe changed the title Tweaks for Sort Icon Styling TH Fixes - Clean-up, efficiency, and Sort Icons fixes Dec 31, 2024
@lrljoe lrljoe merged commit c67247b into rappasoft:development Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant