Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct install_relocatable issues found by libcudf #423

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Correct install_relocatable issues found by libcudf #423

merged 2 commits into from
Jun 8, 2023

Conversation

robertmaynard
Copy link
Contributor

Description

rapidsai/cudf#13513 found 2 issues in the install_relocatable logic that caused LD_PRELOAD setup to fail. This PR corrects those two issues:

  1. The ENVIRONMENT value always needs to be quoted to properly support multiple variables to be set
  2. We need to scan for all cmake_install.cmake starting from the root build directory

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working non-breaking Introduces a non-breaking change 3 - Ready for Review Ready for review by team labels Jun 7, 2023
@robertmaynard robertmaynard requested a review from a team as a code owner June 7, 2023 19:35
vyasr
vyasr approved these changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question of substance, otherwise LGTM.

rapids-cmake/test/detail/generate_installed_CTestTestfile.cmake Show resolved Hide resolved
testing/test/install_relocatable-complex/CMakeLists.txt Outdated Show resolved Hide resolved
testing/test/install_relocatable-complex/CMakeLists.txt Show resolved Hide resolved
testing/test/install_relocatable-complex/tests/CMakeLists.txt Outdated Show resolved Hide resolved
@robertmaynard
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 707f9ad into rapidsai:branch-23.08 Jun 8, 2023
@robertmaynard robertmaynard deleted the bug/correct_bugs_found_by_libcudf branch June 8, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@robertmaynard @vyasr