Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of rapids-get-rapids-version-from-git #402

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Remove usage of rapids-get-rapids-version-from-git #402

merged 1 commit into from
Apr 20, 2023

Conversation

jjacobelli
Copy link
Contributor

Description

Instead of using rapids-get-rapids-version-from-git we can just hardcode the version and use update-version.sh to update it

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.
  • The cmake-format.json is up to date with these changes.
  • I have added new files under rapids-cmake/
    • I have added include guards (include_guard(GLOBAL))
    • I have added the associated docs/ rst file and update the api.rst

@jjacobelli jjacobelli added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Apr 20, 2023
@jjacobelli jjacobelli self-assigned this Apr 20, 2023
@jjacobelli
Remove usage of rapids-get-rapids-version-from-git
7b2ce90 
Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@jjacobelli jjacobelli marked this pull request as ready for review April 20, 2023 17:19
@jjacobelli jjacobelli requested a review from a team as a code owner April 20, 2023 17:19
@ajschmidt8
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit b8e924b into rapidsai:branch-23.06 Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees

@jjacobelli jjacobelli

Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jjacobelli @ajschmidt8 @robertmaynard