rapids-cmake can now be correctly used by multiple adjacent directories #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When in a situation where multiple projects are nested together in the following configuration - root - sub_project_1 - sub_project_2 If sub_project_1 doesn't import all the rapid-cmake components that sub_project_2 requires it will cause bad errors This is fixed by making sure that cmake module paths are always cached
|
@trxcllnt This should fix the issue you are seeing when multiple projects require |
trxcllnt
approved these changes
Jun 25, 2021
robertmaynard
deleted the
bug/support_multiple_ways_to_include_rapids_cmake
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rapids-cmake can now be correctly used by multiple adjacent directories
When in a situation where multiple projects are nested together in the following configuration:
If sub_project_1 doesn't import all the rapid-cmake components thatsub_project_2 requires it will cause weird runtime errors