[Java] Relax cuVS version matching #1544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
cjnolet
added
improvement
Member
|
/ok to test aedc15e |
ldematte
force-pushed
the
java/relax-cuvs-version-checks
branch
from
aedc15e to
9954f99
Compare
ChrisHegarty
approved these changes
Nov 18, 2025
| private static CuVSVersion addReleases(CuVSVersion currentVersion, int numberOfReleases) { | ||
| short candidateMinor = (short) (currentVersion.minor + numberOfReleases * 2); | ||
| short releaseMinor = (short) (candidateMinor % 12); | ||
| short releaseMajor = (short) (currentVersion.major + (candidateMinor / 12)); |
Contributor
|
/ok to test 080952e |
mythrocks
approved these changes
Nov 21, 2025
Contributor
|
CI failures are a result of rapidsai/raft#2813. Should be resolved by rapidsai/raft#2881. |
mythrocks
changed the title
Contributor
|
/ok to test 080952e |
Contributor
|
/ok to test d4d1f4d |
Contributor
|
/merge |
github-project-automation
bot
moved this from In Progress
to Done
in Vector Search, ML, & Data Mining Release Board
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed during a sync, we want to relax version matching/checking between cuvs-java and the cuVS C library.
The rationale is that the C API should be pretty stable, and the cuvs-java bindings to the C API should not be affected by the cuVS version, provided that the API does not change.
For these reasons, we do still want to check that
This PR introduces these checks, allowing cuvs-java to start and bind with C libraries up to 3 more cuVS releases in the future.