Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors API to accept GeoSeries input for projection and trajectory functions #955

Merged
merged 4 commits into from
Feb 23, 2023
Merged

Refactors API to accept GeoSeries input for projection and trajectory functions #955

merged 4 commits into from
Feb 23, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Feb 23, 2023

Description

This PR refactors API to accept GeoSeries input for projection and trajectory functions.

closes #949, closes #950, closes #951, closes #952

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner February 23, 2023 17:27
@isVoid isVoid requested a review from trxcllnt February 23, 2023 17:27
@github-actions github-actions bot added the Python Related to Python code label Feb 23, 2023
@isVoid isVoid requested review from thomcom and removed request for trxcllnt February 23, 2023 17:27
@isVoid isVoid self-assigned this Feb 23, 2023
@isVoid isVoid added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function breaking Breaking change labels Feb 23, 2023
thomcom
thomcom approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@thomcom thomcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work that was a lot of refactoring.

@isVoid
Copy link
Contributor Author

isVoid commented Feb 23, 2023

/merge

@rapids-bot rapids-bot bot merged commit ef368f0 into rapidsai:branch-23.04 Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

Assignees

@isVoid isVoid

Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
2 participants
@isVoid @thomcom