Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors filtering.py, indexing.py to Accept GeoSeries #938

Merged
merged 5 commits into from
Feb 21, 2023
Merged

Refactors filtering.py, indexing.py to Accept GeoSeries #938

merged 5 commits into from
Feb 21, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Feb 15, 2023 •
edited
Loading

Description

closes #936, closes #937

This PR changes quadtree_on_points and points_in_spatial_window to accept a Geoseries of points.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner February 15, 2023 21:24
@isVoid isVoid requested a review from vyasr February 15, 2023 21:24
@isVoid isVoid added the 3 - Ready for Review Ready for review by team label Feb 15, 2023
@github-actions github-actions bot added the Python Related to Python code label Feb 15, 2023
@isVoid isVoid requested review from harrism and thomcom and removed request for vyasr February 15, 2023 21:24
@isVoid isVoid self-assigned this Feb 15, 2023
@isVoid isVoid added breaking Breaking change improvement Improvement / enhancement to an existing function feature request New feature or request and removed feature request New feature or request labels Feb 15, 2023
isVoid and others added 2 commits February 15, 2023 19:30
@isVoid @thomcom
Update python/cuspatial/benchmarks/api/bench_api.py
3ca9547 
Co-authored-by: H. Thomson Comer <thomcom@gmail.com>
@isVoid
style
6d93626
@isVoid
Copy link
Contributor Author

isVoid commented Feb 21, 2023

/merge

@rapids-bot rapids-bot bot merged commit 8299bdc into rapidsai:branch-23.04 Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@harrism harrism Awaiting requested review from harrism

Assignees

@isVoid isVoid

Labels
3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
2 participants
@isVoid @thomcom