Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce error handling verbosity in CI tests scripts #912

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Reduce error handling verbosity in CI tests scripts #912

merged 3 commits into from
Feb 10, 2023

Conversation

AjayThorve
Copy link
Member

This PR adds a less verbose trap method, for error handling to help ensure that we capture all potential error codes in our test scripts, and works as follows:

  • setting an environment variable, EXITCODE, with a default value of 0
  • setting a trap statement triggered by ERR signals which will set EXITCODE=1 when any commands return a non-zero exit code

cc @ajschmidt8

@AjayThorve AjayThorve requested a review from a team as a code owner February 9, 2023 01:02
@github-actions github-actions bot added the ci label Feb 9, 2023
ajschmidt8
ajschmidt8 requested changes Feb 10, 2023
View reviewed changes
ci/test_cpp.sh Show resolved Hide resolved
ajschmidt8
ajschmidt8 approved these changes Feb 10, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🔥

@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 10, 2023
@ajschmidt8
Copy link
Member

ajschmidt8 commented Feb 10, 2023 •
edited
Loading

/merge

@rapids-bot rapids-bot bot merged commit c60c8a2 into rapidsai:branch-23.04 Feb 10, 2023
@ajschmidt8 ajschmidt8 mentioned this pull request Feb 23, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
ci improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AjayThorve @ajschmidt8