Fix a bug preventing align from working with a basic slice.
#850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this fix #848? I saw another related issue as well. Should those issues be added to the current sprint and estimated? |
|
Yes, it is done for Sprint 2. |
|
What about #849? |
thomcom
requested review from
harrism and
isVoid
and removed request for
cwharris
thomcom
added
bug
isVoid
reviewed
Dec 14, 2022
|
rerun tests |
isVoid
approved these changes
Dec 15, 2022
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #848
Description
This PR fixes a bug with
alignso that slicing aGeoSeries, then calling a binpred with slices of theGeoSerieswith unmatching indexes works. It also adds a few more valid tests.As of this PR one test still fails, I'm working on it but it feels like a rabbit hole. I'm inclined to leave the case for later:
The case that doesn't work is the hardest case wherein two
GeoSerieshave different length as well as indexes in one that is not present in the other.Checklist