Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable copy_prs. [skip gpuci] #837

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Enable copy_prs. [skip gpuci] #837

merged 2 commits into from
Dec 2, 2022

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Dec 2, 2022

Description

Enables copying PRs so that GitHub Actions CI can run.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner December 2, 2022 18:14
@bdice bdice changed the title Enable copy_prs. Enable copy_prs. [skip gpuci] Dec 2, 2022
@bdice bdice added gpuCI Related to Continuous Integration / Automation improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Dec 2, 2022
ajschmidt8
ajschmidt8 reviewed Dec 2, 2022
View reviewed changes
.github/ops-bot.yaml Outdated
@@ -6,3 +6,5 @@ branch_checker: true
label_checker: true
release_drafter: true
external_contributors: false
copy_prs: true
rerun_tests: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rerun_tests: true

We should remove this. The current rerun_tests functionality provided by the ops-bot was intended to be used on Jenkins when we were refining our Jenkins process. It's not configured to work with GH Actions. If we keep this enabled, it will start sending invalid HTTP requests to our Jenkins server whenever someone types rerun tests.

Eventually I'll probably rewrite the rerun_tests functionality to work on GH Actions, but I think it's still in use by the nv-morpheus org, who was piloting our refined Jenkins build process. I believe they are in the process of migrating to GH Actions as well, but I haven't followed up with them in a while.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the context and fix!

@github-actions github-actions bot removed the gpuCI Related to Continuous Integration / Automation label Dec 2, 2022
@ajschmidt8 ajschmidt8 merged commit 767e45f into rapidsai:branch-23.02 Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdice @ajschmidt8