Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add find_point_on_segment internal API #819

Merged
merged 11 commits into from
Dec 13, 2022
Merged

Add find_point_on_segment internal API #819

merged 11 commits into from
Dec 13, 2022

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Nov 23, 2022 •
edited by harrism
Loading

Description

This PR adds internal API to find if point can be merged on corresponding segment sets. Closes #817.

Depending on other internal API PRs to add range and update range objects to make this pass compile.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid self-assigned this Nov 23, 2022
@isVoid isVoid added the 2 - In Progress Currenty a work in progress label Nov 23, 2022
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Nov 23, 2022
@isVoid isVoid changed the base branch from branch-22.12 to branch-23.02 November 28, 2022 17:51
@isVoid isVoid added feature request New feature or request non-breaking Non-breaking change labels Nov 28, 2022
harrism
harrism requested changes Dec 6, 2022
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions.

cpp/include/cuspatial/detail/utility/linestring.cuh Outdated Show resolved Hide resolved
cpp/include/cuspatial/detail/utility/linestring.cuh Outdated Show resolved Hide resolved
cpp/include/cuspatial/experimental/detail/find/find_point_on_segments.cuh Outdated Show resolved Hide resolved
cpp/include/cuspatial/experimental/detail/find/find_point_on_segments.cuh Outdated Show resolved Hide resolved
@isVoid isVoid marked this pull request as ready for review December 6, 2022 23:32
@isVoid isVoid requested review from a team as code owners December 6, 2022 23:32
thomcom
thomcom approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@thomcom thomcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@isVoid isVoid mentioned this pull request Dec 10, 2022
Merged
3 tasks
@isVoid
Copy link
Contributor Author

isVoid commented Dec 13, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5dcd22d into rapidsai:branch-23.02 Dec 13, 2022
rapids-bot bot pushed a commit that referenced this pull request Dec 16, 2022
@isVoid
Add Header Only API pairwise_linestring_intersection (#852)
f945e67 
This PR adds header only API `pairwise_linestring_intersection`. Closes #765 .

Depends on #813 #818 #819 #851

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)
  - H. Thomson Comer (https://github.com/thomcom)

URL: #852
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@harrism harrism harrism approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cuspatial-cmake-codeowners

@jrhemstad jrhemstad Awaiting requested review from jrhemstad jrhemstad is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees

@isVoid isVoid

Labels
2 - In Progress Currenty a work in progress cmake Related to CMake code or build configuration feature request New feature or request libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create Internal API to Merge Points to Segments if Point is on the Segment
3 participants
@isVoid @thomcom @harrism