Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Floating Point Equality Tests to Build List #812

Merged

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Nov 22, 2022

Description

#773 added a test utility that checks floating point equality based on ULP difference. However, as a blinded file checkout in #786, the line that builds tests for the floating point utility is removed by mistake. This PR adds that back.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner November 22, 2022 19:37
@isVoid isVoid requested a review from harrism November 22, 2022 19:37
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Nov 22, 2022
@isVoid isVoid self-assigned this Nov 22, 2022
@isVoid isVoid added non-breaking Non-breaking change bug Something isn't working labels Nov 22, 2022
@harrism
Copy link
Member

harrism commented Nov 22, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 19e7661 into rapidsai:branch-22.12 Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants