Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use CMake 3.25.0 as it has a FindCUDAToolkit show stopping bug #805

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Don't use CMake 3.25.0 as it has a FindCUDAToolkit show stopping bug #805

merged 1 commit into from
Nov 18, 2022

Conversation

robertmaynard
Copy link
Contributor

Description

Avoid CMake 3.25.0 as it has an issue that stops cmake execution on conda envs.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard robertmaynard added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Nov 17, 2022
@robertmaynard robertmaynard requested review from a team as code owners November 17, 2022 19:46
@github-actions github-actions bot added conda Related to conda and conda configuration Python Related to Python code labels Nov 17, 2022
harrism
harrism approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. FYI @isVoid

@vyasr
Copy link
Contributor

vyasr commented Nov 17, 2022

Looks like a failure from the gdal pin. Rerunning

@vyasr
Copy link
Contributor

vyasr commented Nov 17, 2022

rerun tests

vyasr
vyasr reviewed Nov 17, 2022
View reviewed changes
conda/recipes/cuspatial/meta.yaml
@@ -29,7 +29,7 @@ requirements:
host:
- python
- cython >=0.29,<0.30
- cmake>=3.23.1
- cmake>=3.23.1,!=3.25.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of scope to fix in this PR, but the cuspatial and libcuspatial libraries should be aligned in terms of where they specify their required versions (conda_build_config.yaml vs meta.yaml) @thomcom @isVoid

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reminder, do you mind filing an issue?

@thomcom
Copy link
Contributor

thomcom commented Nov 18, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit fd5d15d into rapidsai:branch-22.12 Nov 18, 2022
@robertmaynard robertmaynard deleted the bug/avoid_cmake_3.25.0 branch November 21, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@vyasr vyasr vyasr left review comments

@harrism harrism harrism approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working conda Related to conda and conda configuration non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robertmaynard @vyasr @thomcom @harrism @ajschmidt8