-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Multilinestring
in column API and python Bindings for pairwise_linestring_distance
#786
Merged
rapids-bot
merged 4 commits into
rapidsai:branch-22.12
from
isVoid:feature/multilinestring_distance_columnAPI_python
Nov 15, 2022
Merged
Support Multilinestring
in column API and python Bindings for pairwise_linestring_distance
#786
rapids-bot
merged 4 commits into
rapidsai:branch-22.12
from
isVoid:feature/multilinestring_distance_columnAPI_python
Nov 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmake
Related to CMake code or build configuration
libcuspatial
Relates to the cuSpatial C++ library
Python
Related to Python code
labels
Nov 8, 2022
Note that |
isVoid
requested review from
harrism and
thomcom
and removed request for
cwharris and
zhangjianting
November 8, 2022 02:02
3 tasks
isVoid
added
feature request
New feature or request
non-breaking
Non-breaking change
labels
Nov 8, 2022
harrism
approved these changes
Nov 9, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
…into feature/multilinestring_distance_columnAPI_python
isVoid
added
5 - Ready to Merge
Testing and reviews complete, ready to merge
and removed
3 - Ready for Review
Ready for review by team
labels
Nov 11, 2022
thomcom
approved these changes
Nov 15, 2022
@gpucibot merge |
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Nov 22, 2022
#773 added a test utility that checks floating point equality based on ULP difference. However, as a blinded file checkout in #786, the line that builds tests for the floating point utility is removed by mistake. This PR adds that back. Authors: - Michael Wang (https://github.com/isVoid) Approvers: - Mark Harris (https://github.com/harrism) URL: #812
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
5 - Ready to Merge
Testing and reviews complete, ready to merge
cmake
Related to CMake code or build configuration
feature request
New feature or request
libcuspatial
Relates to the cuSpatial C++ library
non-breaking
Non-breaking change
Python
Related to Python code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a port of the second half of #753, closes #706
Checklist