Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Multilinestring in column API and python Bindings for pairwise_linestring_distance #786

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Nov 8, 2022

Description

This is a port of the second half of #753, closes #706

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid added the 3 - Ready for Review Ready for review by team label Nov 8, 2022
@isVoid isVoid self-assigned this Nov 8, 2022
@isVoid isVoid requested review from a team as code owners November 8, 2022 02:01
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library Python Related to Python code labels Nov 8, 2022
@isVoid
Copy link
Contributor Author

isVoid commented Nov 8, 2022

Note that linestring_distance_test_medium.cu has over 1300+ loc. If you mask out this file actual line changes is not that big.

@isVoid isVoid requested review from harrism and thomcom and removed request for cwharris and zhangjianting November 8, 2022 02:02
@isVoid isVoid added feature request New feature or request non-breaking Non-breaking change labels Nov 8, 2022
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@isVoid isVoid added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Nov 11, 2022
@harrism harrism added c++ and removed libcuspatial Relates to the cuSpatial C++ library labels Nov 14, 2022
@isVoid
Copy link
Contributor Author

isVoid commented Nov 15, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3fad242 into rapidsai:branch-22.12 Nov 15, 2022
@harrism harrism added libcuspatial Relates to the cuSpatial C++ library and removed c++ labels Nov 16, 2022
rapids-bot bot pushed a commit that referenced this pull request Nov 22, 2022
#773 added a test utility that checks floating point equality based on ULP difference. However, as a blinded file checkout in #786, the line that builds tests for the floating point utility is removed by mistake. This PR adds that back.

Authors:
  - Michael Wang (https://github.com/isVoid)

Approvers:
  - Mark Harris (https://github.com/harrism)

URL: #812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge cmake Related to CMake code or build configuration feature request New feature or request libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change Python Related to Python code
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Simplify header-only linestring_distance API, support multilinestring
3 participants