-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing markdown issue templates with yml forms #748
Replacing markdown issue templates with yml forms #748
Conversation
To see the forms in action and try them out to see what changes you may want, you can view the templates by creating issues in the feature branch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. I think there are some opportunities to streamline.
Co-authored-by: Mark Harris <mharris@nvidia.com>
Co-authored-by: Mark Harris <mharris@nvidia.com>
Co-authored-by: Mark Harris <mharris@nvidia.com>
@harrism I've added a new yml - documentation_request.yml as a possible single replacement for both of the previous doc forms. If looks good, will delete the old doc forms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple more suggestions for clarity, then I approve. Would be good to get one more review.
- Critical (currently preventing usage) | ||
- High | ||
- Medium | ||
- Low (would be nice) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess I prefer two options high and low, mostly just because of decision-making pressure when working through these forms.
Co-authored-by: H. Thomson Comer <thomcom@gmail.com> Co-authored-by: Mark Harris <mharris@nvidia.com>
All changes incorporated aside from Thomson's good idea for the Once we have that resolved, this should be good to go. |
Can we just create an issue for print_env.sh and then get this merged independent of it? |
I'll make the issue for it now, and will request an ops review for merge. |
@gpucibot merge |
Description
This PR replaces the existing markdown issue templates with form-based YML templates. They provide a more interactive experience and can require certain fields be filled out prior to issue submission.
Checklist
The documentation is up to date with these changes.