Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header-only trajectory_bounding_boxes #741

Merged
merged 32 commits into from
Oct 24, 2022
Merged

Header-only trajectory_bounding_boxes #741

merged 32 commits into from
Oct 24, 2022

Conversation

harrism
Copy link
Member

@harrism harrism commented Oct 18, 2022 •
edited
Loading

Contributes to #563

Header-only refactoring of cuspatial::trajectory_bounding_boxes

Note the commit list is messy because it was originally based off of #628 which was merged into 22.10.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

harrism and others added 21 commits August 4, 2022 11:16
@harrism
Header-only refactoring of derive_trajectories
a189125
@harrism
Merge branch 'branch-22.10' into fea-header-only-derive-trajectories
f176d77
@harrism
Rename test to .cpp and add exception tests.
0a2e458
@harrism
Remove comment.
f7084bf
@harrism
Add empty test
8da63a7
@harrism
Fix includes
6a171f4
@harrism
Add data generator and test
d3a4c86
@harrism
Remove cudf_test dependency and further refactor derive_trajectory tests
26f3e16
@harrism
More tests
1983158
@harrism
Merge branch 'branch-22.10' into fea-header-only-derive-trajectories
ac9355d
@harrism
Fix includes
7093d27
@harrism
Merge branch 'branch-22.10' into fea-header-only-derive-trajectories
3fd8794
@harrism
Fix derive trajectories column-based API failure
ad78166
@harrism
device_vector -> device_uvector
b7acee6
@harrism
Apply suggestions from @isVoid review.
528c656
@harrism @thomcom
Apply suggestions from code review
1a2a814 
Co-authored-by: H. Thomson Comer <thomcom@gmail.com>
@harrism
Clarify description of reordering.
235ceb3
@harrism
Add vec_2d::min and max
c46bfbb
@harrism
Merge branch 'branch-22.10' into fea-header-only-trajectory-bb
62dc9d4
@harrism
Merge branch 'branch-22.12' into fea-header-only-trajectory-bb
7f4b632
@harrism
Header-only trajectory bounding boxes
3707b1a
@harrism harrism added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 18, 2022
@harrism harrism added this to the header-only C++ API milestone Oct 18, 2022
@harrism harrism self-assigned this Oct 18, 2022
@harrism harrism requested review from a team as code owners October 18, 2022 06:46
@github-actions github-actions bot added the cmake Related to CMake code or build configuration label Oct 18, 2022
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Oct 18, 2022
@harrism harrism added 3 - Ready for Review Ready for review by team and removed cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Oct 18, 2022
isVoid
isVoid reviewed Oct 19, 2022
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just small questions.

cpp/src/trajectory/trajectory_bounding_boxes.cu Outdated Show resolved Hide resolved
cpp/include/cuspatial/experimental/trajectory_bounding_boxes.cuh Outdated Show resolved Hide resolved
cpp/tests/experimental/trajectory/trajectory_test_utils.cuh Show resolved Hide resolved
cpp/tests/experimental/trajectory/trajectory_test_utils.cuh Show resolved Hide resolved
cpp/include/cuspatial/experimental/trajectory_bounding_boxes.cuh Outdated Show resolved Hide resolved
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Oct 19, 2022
@harrism harrism requested a review from thomcom October 24, 2022 21:12
@harrism
Copy link
Member Author

harrism commented Oct 24, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit ca31988 into rapidsai:branch-22.12 Oct 24, 2022
@harrism harrism mentioned this pull request Nov 3, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trxcllnt trxcllnt trxcllnt approved these changes

@isVoid isVoid isVoid approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cuspatial-cmake-codeowners

@zhangjianting zhangjianting Awaiting requested review from zhangjianting zhangjianting is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

@thomcom thomcom Awaiting requested review from thomcom

Assignees

@harrism harrism

Labels
3 - Ready for Review Ready for review by team cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Done
Milestone
header-only C++ API
Development

Successfully merging this pull request may close these issues.
3 participants
@harrism @trxcllnt @isVoid