Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python bindings for (multi)point-(multi)point distance #734

Merged
merged 31 commits into from
Oct 25, 2022
Merged

Add python bindings for (multi)point-(multi)point distance #734

merged 31 commits into from
Oct 25, 2022

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Oct 7, 2022 •
edited
Loading

Description

This PR adds python bindings to Point-point distance. Depend on #731
Reverts change to comment: #731 (comment)

Close #578

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library Python Related to Python code labels Oct 7, 2022
@harrism harrism added this to the ST_Distance milestone Oct 10, 2022
@isVoid isVoid mentioned this pull request Oct 19, 2022
Merged
3 tasks
@isVoid isVoid marked this pull request as ready for review October 19, 2022 20:45
@isVoid isVoid requested review from a team as code owners October 19, 2022 20:45
@isVoid isVoid linked an issue Oct 19, 2022 that may be closed by this pull request
Simplify header-only point_distance API, support multipoint #704
Closed
@isVoid isVoid self-assigned this Oct 19, 2022
@isVoid isVoid requested review from harrism and thomcom and removed request for trxcllnt and zhangjianting October 19, 2022 20:45
@isVoid isVoid added breaking Breaking change feature request New feature or request labels Oct 19, 2022
harrism
harrism approved these changes Oct 19, 2022
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty straightforward wrapper. Looks good.

thomcom
thomcom requested changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@thomcom thomcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python looks really solid with easy to read and comprehensive tests. Just a question and a concern about the example that you give in the python docs.

python/cuspatial/cuspatial/core/spatial/distance.py Show resolved Hide resolved
cpp/tests/spatial/point_distance_test.cpp Show resolved Hide resolved
@isVoid isVoid requested a review from thomcom October 25, 2022 20:37
@isVoid
Copy link
Contributor Author

isVoid commented Oct 25, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cf5117b into rapidsai:branch-22.12 Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@harrism harrism harrism approved these changes

Assignees

@isVoid isVoid

Labels
breaking Breaking change cmake Related to CMake code or build configuration feature request New feature or request libcuspatial Relates to the cuSpatial C++ library Python Related to Python code
Projects
cuSpatial
Status: Done
Milestone
ST_Distance
Development

Successfully merging this pull request may close these issues.

Simplify header-only point_distance API, support multipoint [FEA] Python bindings for point-point distance
3 participants
@isVoid @thomcom @harrism