Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that minimum required CMake version is now 3.23.1 #689

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Document that minimum required CMake version is now 3.23.1 #689

merged 1 commit into from
Sep 27, 2022

Conversation

robertmaynard
Copy link
Contributor

Description

With rapids-cmake now requiring CMake 3.23.1 update consumers to correctly express this requirement

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@robertmaynard
Document that minimum required CMake version is now 3.23.1
300733a 
With rapids-cmake now requiring CMake 3.23.1 update consumers
to correctly express this requirement
@robertmaynard robertmaynard added 3 - Ready for Review Ready for review by team doc Documentation non-breaking Non-breaking change labels Sep 23, 2022
@robertmaynard robertmaynard requested review from a team as code owners September 23, 2022 19:11
@github-actions github-actions bot added cmake Related to CMake code or build configuration conda Related to conda and conda configuration libcuspatial Relates to the cuSpatial C++ library java Python Related to Python code labels Sep 23, 2022
@harrism harrism removed the request for review from zhangjianting September 27, 2022 01:23
@harrism
Copy link
Member

harrism commented Sep 27, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 6c12b1a into rapidsai:branch-22.10 Sep 27, 2022
@robertmaynard robertmaynard deleted the update_cmake_version branch September 27, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@jjacobelli jjacobelli jjacobelli approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team cmake Related to CMake code or build configuration conda Related to conda and conda configuration doc Documentation libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertmaynard @harrism @jjacobelli