Python API for point-linestring nearest points #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_linestring_distance
This reverts commit a8ec5ff.
This reverts commit 2ed60eb.
…into feature/header_only_point_linestring_distance
Co-authored-by: Mark Harris <mharris@nvidia.com>
…b.com:isVoid/cuspatial into feature/header_only_point_linestring_distance
…into feature/header_only_point_linestring_distance
…into feature/python_point_linestring_nearest_points
…tring_nearest_points
thomcom
requested changes
Sep 23, 2022
| check_dtype=False, | ||
| check_index_type=False, | ||
| check_less_precise=True, | ||
| ) |
There was a problem hiding this comment.
You have many failure cases in the python code that you aren't testing for here, like https://github.com/rapidsai/cuspatial/pull/681/files#diff-6e59ef32765771de56798ec48c85a59ba2bb65f4c10f6e06326a59ad82a793ffR42, also lines 56, 59, and 64.
There was a problem hiding this comment.
I've added all failure case tests except line 64 because I don't think notimplementederror should be tested (as it will be removed). Let me know if you insist.
|
Looks really good. I think you need some more failure cases in python and a noticed a couple of variable renamings. |
…into feature/python_point_linestring_nearest_points
harrism
approved these changes
Sep 27, 2022
|
@gpucibot merge |
|
For some reason I thought I had it... welp, no rush then. |
thomcom
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds python API for point-linestring nearest points. Closes #646 .
Depend on #658 #686
This PR also moves
Feature_Enumfrom io module to geometa module to make sure the coding is consistent and reused throughout the codebase.Checklist