Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lonlat_2d and cartesian_2d types #662

Merged
merged 5 commits into from
Aug 25, 2022
Merged

Remove lonlat_2d and cartesian_2d types #662

merged 5 commits into from
Aug 25, 2022

Conversation

harrism
Copy link
Member

@harrism harrism commented Aug 24, 2022

Closes #653. Removes lonlat_2d<T> and cartesian_2d structs and related iterator factories and replaces all usage of these structs with their base class `vec_2d. See #653 for discussion / motivation.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism added improvement Improvement / enhancement to an existing function breaking Breaking change c++ labels Aug 24, 2022
@harrism harrism requested a review from a team as a code owner August 24, 2022 12:18
@harrism harrism self-assigned this Aug 24, 2022
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Aug 24, 2022
thomcom
thomcom approved these changes Aug 24, 2022
View reviewed changes
cpp/doc/libcuspatial_refactoring_guide.md Outdated Show resolved Hide resolved
isVoid
isVoid approved these changes Aug 24, 2022
View reviewed changes
cpp/benchmarks/pairwise_linestring_distance.cu Outdated Show resolved Hide resolved
@harrism
Copy link
Member Author

harrism commented Aug 25, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit af7bab8 into rapidsai:branch-22.10 Aug 25, 2022
@harrism harrism removed the c++ label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trxcllnt trxcllnt trxcllnt approved these changes

@thomcom thomcom thomcom approved these changes

@isVoid isVoid isVoid approved these changes

@zhangjianting zhangjianting Awaiting requested review from zhangjianting zhangjianting is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees

@harrism harrism

Labels
breaking Breaking change improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library
Projects
cuSpatial
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Remove cartesian_2d and lonlat_2d distinction and use vec_2d universally
4 participants
@harrism @trxcllnt @thomcom @isVoid