-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmark for points_in_spatial_window #595
Merged
rapids-bot
merged 6 commits into
rapidsai:branch-22.08
from
harrism:fea-spatial-window-benchmark
Jul 27, 2022
Merged
Add benchmark for points_in_spatial_window #595
rapids-bot
merged 6 commits into
rapidsai:branch-22.08
from
harrism:fea-spatial-window-benchmark
Jul 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
cmake
Related to CMake code or build configuration
libcuspatial
Relates to the cuSpatial C++ library
labels
Jul 19, 2022
harrism
added
3 - Ready for Review
Ready for review by team
feature request
New feature or request
improvement
Improvement / enhancement to an existing function
and removed
feature request
New feature or request
labels
Jul 19, 2022
harrism
added
c++
non-breaking
Non-breaking change
benchmarks
Related to benchmarks
labels
Jul 19, 2022
harrism
requested review from
isVoid and
trxcllnt
and removed request for
jrhemstad and
zhangjianting
July 19, 2022 07:11
thomcom
approved these changes
Jul 19, 2022
Co-authored-by: H. Thomson Comer <thomcom@gmail.com>
isVoid
reviewed
Jul 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a few questions. But nothing stops it from merging.
isVoid
approved these changes
Jul 27, 2022
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3 - Ready for Review
Ready for review by team
benchmarks
Related to benchmarks
cmake
Related to CMake code or build configuration
improvement
Improvement / enhancement to an existing function
libcuspatial
Relates to the cuSpatial C++ library
non-breaking
Non-breaking change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently calls the cuDF-based C++ API for
points_in_spatial_window
, in order to capture "before refactoring" throughput of the API. I plan to also run the post-refactoring version, and then update the benchmark to run the refactored API in order to not depend on libcudf in this benchmark.