Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark for points_in_spatial_window #595

Merged

Conversation

harrism
Copy link
Member

@harrism harrism commented Jul 19, 2022

This currently calls the cuDF-based C++ API for points_in_spatial_window, in order to capture "before refactoring" throughput of the API. I plan to also run the post-refactoring version, and then update the benchmark to run the refactored API in order to not depend on libcudf in this benchmark.

@harrism harrism requested review from a team as code owners July 19, 2022 07:09
@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Jul 19, 2022
@harrism harrism added this to the header-only C++ API milestone Jul 19, 2022
@harrism harrism added 3 - Ready for Review Ready for review by team feature request New feature or request improvement Improvement / enhancement to an existing function and removed feature request New feature or request labels Jul 19, 2022
@harrism harrism self-assigned this Jul 19, 2022
@harrism harrism added c++ non-breaking Non-breaking change benchmarks Related to benchmarks labels Jul 19, 2022
@harrism harrism requested review from isVoid and trxcllnt and removed request for jrhemstad and zhangjianting July 19, 2022 07:11
cpp/benchmarks/pairwise_linestring_distance.cu Outdated Show resolved Hide resolved
cpp/benchmarks/utility/random.cuh Show resolved Hide resolved
cpp/benchmarks/utility/random.cuh Show resolved Hide resolved
harrism and others added 2 commits July 20, 2022 09:33
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few questions. But nothing stops it from merging.

cpp/benchmarks/spatial_window.cu Show resolved Hide resolved
cpp/benchmarks/spatial_window.cu Show resolved Hide resolved
cpp/benchmarks/spatial_window.cu Outdated Show resolved Hide resolved
@harrism harrism requested a review from isVoid July 26, 2022 10:19
@harrism
Copy link
Member Author

harrism commented Jul 27, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit dbb30e5 into rapidsai:branch-22.08 Jul 27, 2022
@harrism harrism removed the c++ label Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team benchmarks Related to benchmarks cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants