Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use conda to build python packages during GPU tests #517

Merged
merged 1 commit into from
May 10, 2022
Merged

Use conda to build python packages during GPU tests #517

merged 1 commit into from
May 10, 2022

Conversation

jjacobelli
Copy link
Contributor

@jjacobelli jjacobelli commented Apr 19, 2022 •
edited
Loading

This PR convert the from sources build we are doing in GPU test job to a conda build. This is done for the following reasons:

  • This is required step to improve the Ops CI/CD setup to a more convenient pipeline
  • This is required to start using conda compilers and mamba to build RAPIDS packages
  • This prevent us from manually managing and installing the dependencies in GPU job
  • This ensure the packages can be installed
  • This ensure the tests are running and working against the package content and not the build results. Currently the Python packages are not tested.

This may increase the global pipeline time, but the usage of mamba should resolve this as mamba is faster than conda to build packages

@jjacobelli jjacobelli added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 19, 2022
@jjacobelli jjacobelli self-assigned this Apr 19, 2022
@github-actions github-actions bot added the gpuCI Related to Continuous Integration / Automation label Apr 19, 2022
@jjacobelli jjacobelli force-pushed the remove-from-soures branch 3 times, most recently from 487a4fb to 1a3e599 Compare April 19, 2022 17:36
@jjacobelli
Copy link
Contributor Author

rerun tests

@github-actions github-actions bot added the Python Related to Python code label Apr 20, 2022
@jjacobelli jjacobelli added the 5 - DO NOT MERGE Hold off on merging; see PR for details label Apr 20, 2022
@jjacobelli
Use conda to build python packages during GPU tests
aa6d66d 
Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@jjacobelli jjacobelli removed the 5 - DO NOT MERGE Hold off on merging; see PR for details label Apr 25, 2022
@jjacobelli jjacobelli marked this pull request as ready for review April 25, 2022 09:38
@jjacobelli jjacobelli requested review from a team as code owners April 25, 2022 09:38
isVoid
isVoid approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python approval

@isVoid
Copy link
Contributor

isVoid commented May 9, 2022

Oops, I realized I'm not the python code owner yet 😅

@harrism
Copy link
Member

harrism commented May 10, 2022

Oops, I realized I'm not the python code owner yet 😅

You are now.

harrism
harrism approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python approval (there's no Python code. :) )

@jjacobelli
Copy link
Contributor Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 4077552 into rapidsai:branch-22.06 May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@isVoid isVoid isVoid approved these changes

Assignees

@jjacobelli jjacobelli

Labels
gpuCI Related to Continuous Integration / Automation improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjacobelli @isVoid @harrism @ajschmidt8