Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Upgrade clang to 11.1.0 #463

Merged
merged 1 commit into from
Nov 18, 2021

Conversation

galipremsagar
Copy link
Contributor

This upgrade is required to be in-line with: rapidsai/cudf#9716

Depends on: rapidsai/integration#390

@galipremsagar galipremsagar requested review from a team as code owners November 17, 2021 15:52
@github-actions github-actions bot added conda Related to conda and conda configuration libcuspatial Relates to the cuSpatial C++ library labels Nov 17, 2021
@harrism harrism added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 17, 2021
@harrism
Copy link
Member

harrism commented Nov 17, 2021

I guess this won't pass until CI version of clang-format is upgraded.

>>>> FAILED: clang format check; begin output
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
Traceback (most recent call last):
  File "cpp/scripts/run-clang-format.py", line 142, in <module>
    main()
  File "cpp/scripts/run-clang-format.py", line 118, in main
    args = parse_args()
  File "cpp/scripts/run-clang-format.py", line 66, in parse_args
    (EXPECTED_VERSION, version))
Exception: clang-format exe must be v11.1.0 found '11.0.0'
>>>> FAILED: clang format check; end output

@galipremsagar
Copy link
Contributor Author

I guess this won't pass until CI version of clang-format is upgraded.

>>>> FAILED: clang format check; begin output
/bin/sh: warning: setlocale: LC_ALL: cannot change locale (C.UTF-8)
Traceback (most recent call last):
  File "cpp/scripts/run-clang-format.py", line 142, in <module>
    main()
  File "cpp/scripts/run-clang-format.py", line 118, in main
    args = parse_args()
  File "cpp/scripts/run-clang-format.py", line 66, in parse_args
    (EXPECTED_VERSION, version))
Exception: clang-format exe must be v11.1.0 found '11.0.0'
>>>> FAILED: clang format check; end output

Yes Mark, that's correct. The CI changes rapidsai/integration#390 have been merged but will likely take some time for new images to be out

@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar
Copy link
Contributor Author

@gpucibot merge

@ajschmidt8 ajschmidt8 merged commit ccaf41d into rapidsai:branch-21.12 Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants