[REVIEW] from_geopandas converts GeoPandas GeoSeries objects into cuspatial GeoArrow form.
#300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…which are multi and which are not, yet, that'll take another consideration.
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
|
Moving to 0.17. BTW, if you use a draft PR, there's no need for [WIP] / [REVIEW] anymore. |
Co-authored-by: Keith Kraus <kkraus@nvidia.com>
|
@kkraus14 I've resolved all of your comments! Please to confirm approval. |
kkraus14
reviewed
May 11, 2021
kkraus14
approved these changes
May 12, 2021
kkraus14
added
5 - Ready to Merge
|
🎉 |
|
@dillon-cullinan @ajschmidt8 looks like I need an ops approval, I don't think it is necessary. |
ajschmidt8
reviewed
May 14, 2021
ajschmidt8
changed the title
from_geopandas converts GeoPandas GeoSeries objects into cuspatial GeoArrow form.from_geopandas converts GeoPandas GeoSeries objects into cuspatial GeoArrow form.
ajschmidt8
changed the title
from_geopandas converts GeoPandas GeoSeries objects into cuspatial GeoArrow form. from_geopandas converts GeoPandas GeoSeries objects into cuspatial GeoArrow form.
ajschmidt8
approved these changes
May 21, 2021
kkraus14
reviewed
May 21, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
from_geopandasfeature, creating aGeoSeriesobject backed by GPU memory and GeoArrow format as discussed with GeoPandas team members.This PR also provides
to_geopandas, putting cuspatial GPU memory back into a GeoPandasGeoSeriesobject.