Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address cudf.DataFrame.insert API change #1428

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Aug 1, 2024

Description

closes #1427

The API of cudf.DataFrame.insert will change in 24.10 to better align with pandas, so adjusting the usage here

xref rapidsai/cudf#16402

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke requested a review from a team as a code owner August 1, 2024 23:00
@github-actions github-actions bot added the Python Related to Python code label Aug 1, 2024
@mroeschke mroeschke changed the title Address cudf.Index.insert API change Address cudf.DataFrame.insert API change Aug 1, 2024
@jameslamb
Copy link
Member

With this

git grep -E '\.insert'

I found one more case that looks like it also needs to be changed:

recombiner.insert(
loc=n,
name=name,
value=cudf_reindexed[name].reset_index(drop=True),
)

@mroeschke
Copy link
Contributor Author

With this

Thanks! My local search missed this 😅

@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 5, 2024
@jameslamb
Copy link
Member

Thanks @mroeschke!

@jameslamb
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 3906fb9 into rapidsai:branch-24.10 Aug 7, 2024
69 checks passed
@mroeschke mroeschke deleted the fix/insert branch August 7, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
Status: Review
Development

Successfully merging this pull request may close these issues.

[BUG]: reset_index tests failing: "insert() got an unexpected keyword argument 'name'"
3 participants