Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split up CUDA-suffixed dependencies in dependencies.yaml #1414

Merged
merged 5 commits into from
Jul 25, 2024

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#31

In short, RAPIDS DLFW builds want to produce wheels with unsuffixed dependencies, e.g. cudf depending on rmm, not rmm-cu12.

This PR is part of a series across all of RAPIDS to try to support that type of build by setting up CUDA-suffixed and CUDA-unsuffixed dependency lists in dependencies.yaml.

For more details, see:

Notes for Reviewers

Why target 24.08?

This is targeting 24.08 because:

  1. it should be very low-risk
  2. getting these changes into 24.08 prevents the need to carry around patches for every library in DLFW builds using RAPIDS 24.08

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added 2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 24, 2024
@github-actions github-actions bot added the Python Related to Python code label Jul 24, 2024
@jameslamb jameslamb changed the title WIP: split up CUDA-suffixed dependencies in dependencies.yaml split up CUDA-suffixed dependencies in dependencies.yaml Jul 24, 2024
@jameslamb jameslamb marked this pull request as ready for review July 24, 2024 05:47
@jameslamb jameslamb requested a review from a team as a code owner July 24, 2024 05:47
@jameslamb jameslamb requested a review from AyodeAwe July 24, 2024 05:47
@jameslamb
Copy link
Member Author

These tests are failing, for both wheels and conda packages, with dozens of errors like this:

FAILED tests/binpreds/test_contains_properly.py::test_point_in_polygon[point14-polygon14-True] - ValueError: All data.values() must be Column, not Series

(build link)

I strongly suspect that's related to some recent change in cudf, and not the changes in this PR.

@jameslamb jameslamb added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currenty a work in progress labels Jul 24, 2024
@jameslamb
Copy link
Member Author

jameslamb commented Jul 24, 2024

I've updated this based on the suggestions from rapidsai/cudf#16183.

Ran the following to check update-version.sh.

git fetch upstream --tags
ci/release/update-version.sh '24.10.00'

git grep -E '24\.8|24\.08'

Did not find any required changes for that script.

@jameslamb
Copy link
Member Author

I strongly suspect that's related to some recent change in cudf, and not the changes in this PR.

@mroeschke confirmed offline that these failing tests are unrelated to this PR's changes, and this is safe to admin-merge.

@jameslamb
Copy link
Member Author

Cancelling CI here (and will on other commits in the next 24 hours) to save some CI capacity for other projects that are about to enter code freeze.

@vyasr
Copy link
Contributor

vyasr commented Jul 25, 2024

/merge

@rapids-bot rapids-bot bot merged commit 58d4212 into rapidsai:branch-24.08 Jul 25, 2024
73 checks passed
@jameslamb jameslamb deleted the suffix-split branch July 25, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants