Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coding of RAPIDS version where possible #1357

Merged
merged 2 commits into from
Mar 12, 2024
Merged

Remove hard-coding of RAPIDS version where possible #1357

merged 2 commits into from
Mar 12, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

Description

  • Read VERSION file in CMake
  • Read cuspatial.__version__ and cuproj.__version__ in docs build
  • Read VERSION file in shell scripts
  • Use environment variable substitution in Doxygen
  • Remove updates from ci/release/update-version.sh

Issue: rapidsai/build-planning#15

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners March 6, 2024 22:14
@github-actions github-actions bot added cmake Related to CMake code or build configuration Python Related to Python code libcuspatial Relates to the cuSpatial C++ library Java Related to Java code ci labels Mar 6, 2024
@KyleFromNVIDIA KyleFromNVIDIA added 2 - In Progress Currenty a work in progress cmake Related to CMake code or build configuration Python Related to Python code improvement Improvement / enhancement to an existing function non-breaking Non-breaking change libcuspatial Relates to the cuSpatial C++ library Java Related to Java code ci 3 - Ready for Review Ready for review by team and removed cmake Related to CMake code or build configuration Python Related to Python code libcuspatial Relates to the cuSpatial C++ library Java Related to Java code ci 2 - In Progress Currenty a work in progress labels Mar 6, 2024
harrism
harrism approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bdice
Copy link
Contributor

bdice commented Mar 12, 2024

/merge

@rapids-bot rapids-bot bot merged commit f410685 into rapidsai:branch-24.04 Mar 12, 2024
71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harrism harrism harrism approved these changes

@bdice bdice bdice approved these changes

@AyodeAwe AyodeAwe AyodeAwe approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cuspatial-cmake-codeowners

@trxcllnt trxcllnt Awaiting requested review from trxcllnt trxcllnt is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team ci cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function Java Related to Java code libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KyleFromNVIDIA @bdice @harrism @AyodeAwe