-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Python 3.11, require NumPy 1.23+ #1348
Conversation
Looking into adding |
Thanks James! 🙏 There are definitely required
... |
Oh wow! @jakirkham I hadn't noticed those |
Just moved |
Yeah AFAICT cuProj only uses NumPy in tests. So this seems right
|
/merge |
Thanks all! 🙏 |
Description
Contributes to rapidsai/build-planning#3
This PR adds support for Python 3.11.
It also proposes:
numpy
as a runtime dependency, ascuspatial
does import it directlyNumPy
ofnumpy>=1.23
in tests, see Add support for Python 3.11 build-planning#3 (comment)Notes for Reviewers
This is part of ongoing work to add Python 3.11 support across RAPIDS.
The Python 3.11 CI workflows introduced in rapidsai/shared-workflows#176 are optional... they are not yet required to run successfully for PRs to be merged.
This PR can be merged once all jobs are running successfully (including the non-required jobs for Python 3.11). The CI logs should be verified that the jobs are building and testing with Python 3.11.
See rapidsai/shared-workflows#176 for more details.