Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.11, require NumPy 1.23+ #1348

Merged
merged 9 commits into from
Feb 29, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Feb 26, 2024

Description

Contributes to rapidsai/build-planning#3

This PR adds support for Python 3.11.

It also proposes:

Notes for Reviewers

This is part of ongoing work to add Python 3.11 support across RAPIDS.

The Python 3.11 CI workflows introduced in rapidsai/shared-workflows#176 are optional... they are not yet required to run successfully for PRs to be merged.

This PR can be merged once all jobs are running successfully (including the non-required jobs for Python 3.11). The CI logs should be verified that the jobs are building and testing with Python 3.11.

See rapidsai/shared-workflows#176 for more details.

@github-actions github-actions bot added the conda Related to conda and conda configuration label Feb 26, 2024
@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Feb 27, 2024
@github-actions github-actions bot added the Python Related to Python code label Feb 27, 2024
@jameslamb jameslamb marked this pull request as ready for review February 27, 2024 16:31
@jameslamb jameslamb requested review from a team as code owners February 27, 2024 16:31
@jameslamb jameslamb changed the title Add support for Python 3.11 Add support for Python 3.11, require NumPy 1.23+ in tests Feb 28, 2024
@jameslamb
Copy link
Member Author

Looking into adding numpy>=1.23 as we're pursuing in the other Python 3.11 PRs, I noticed that this project has tests that use numpy but doesn't list numpy explicitly as a test dependency. Pushed 6738d01 to fix that.

@jakirkham
Copy link
Member

Thanks James! 🙏

There are definitely required imports of NumPy in the library. So agree it should be a dependency

...

@jameslamb
Copy link
Member Author

Oh wow! @jakirkham I hadn't noticed those numpy imports outside of the tests. Given that, my proposal on the diff here to add numpy as a testing dependency isn't enough and it should become a runtime dependency. I can update this PR with that change.

@jameslamb
Copy link
Member Author

Just moved numpy into runtime dependencies for cuspatial (in pyproject.toml and the conda recipe).

@jakirkham
Copy link
Member

jakirkham commented Feb 29, 2024

Yeah AFAICT cuProj only uses NumPy in tests. So this seems right

@jameslamb jameslamb changed the title Add support for Python 3.11, require NumPy 1.23+ in tests Add support for Python 3.11, require NumPy 1.23+ Feb 29, 2024
@KyleFromNVIDIA
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 59972f6 into rapidsai:branch-24.04 Feb 29, 2024
73 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

@jameslamb jameslamb deleted the python-3.11 branch February 29, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda Related to conda and conda configuration improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Related to Python code
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

5 participants