Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add curl for notebook testing #1281

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

raydouglass
Copy link
Member

@raydouglass raydouglass commented Oct 10, 2023

Description

Adds curl as a notebook dependency which is used in two notebooks: notebooks/nyc_taxi_years_correlation.ipynb & notebooks/ZipCodes_Stops_PiP_cuSpatial.ipynb (https://github.com/search?q=repo%3Arapidsai%2Fcuspatial+curl&type=code).

This is similar to rapidsai/cugraph#3918 and will fix errors in the notebooks tests in rapidsai/docker.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@raydouglass raydouglass requested a review from a team as a code owner October 10, 2023 16:49
@raydouglass raydouglass added bug Something isn't working non-breaking Non-breaking change labels Oct 10, 2023
@github-actions github-actions bot added conda Related to conda and conda configuration and removed bug Something isn't working non-breaking Non-breaking change labels Oct 10, 2023
@raydouglass raydouglass added bug Something isn't working non-breaking Non-breaking change labels Oct 10, 2023
@raydouglass raydouglass merged commit 32d908f into rapidsai:branch-23.10 Oct 10, 2023
58 of 59 checks passed
@raydouglass raydouglass deleted the notebooks-curl branch October 10, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conda Related to conda and conda configuration non-breaking Non-breaking change
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants