Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove osmnx dependency and use a small local dataset #1195

Merged
merged 8 commits into from
Jun 9, 2023
Merged

Remove osmnx dependency and use a small local dataset #1195

merged 8 commits into from
Jun 9, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Jun 8, 2023

Description

close #1194
This PR removes osmnx dependency and instead use a small locally hosted dataset.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@isVoid isVoid self-assigned this Jun 8, 2023
@isVoid isVoid added bug Something isn't working doc Documentation non-breaking Non-breaking change labels Jun 8, 2023
@isVoid isVoid requested a review from a team as a code owner June 8, 2023 22:14
@github-actions github-actions bot added the conda Related to conda and conda configuration label Jun 8, 2023
@isVoid isVoid removed the bug Something isn't working label Jun 9, 2023
@isVoid isVoid requested a review from bdice June 9, 2023 15:09
@github-actions github-actions bot added the Python Related to Python code label Jun 9, 2023
ajschmidt8
ajschmidt8 approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

@isVoid
Copy link
Contributor Author

isVoid commented Jun 9, 2023

/merge

@rapids-bot rapids-bot bot merged commit 72edee1 into rapidsai:branch-23.08 Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomcom thomcom thomcom approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

@bdice bdice Awaiting requested review from bdice

Assignees

@isVoid isVoid

Labels
conda Related to conda and conda configuration doc Documentation non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Remove external web service dependency in notebooks
4 participants
@isVoid @thomcom @bdice @ajschmidt8