Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update version #1187

Merged
merged 2 commits into from
Jun 7, 2023
Merged

Conversation

raydouglass
Copy link
Member

@raydouglass raydouglass commented Jun 7, 2023

Updates update-version.sh to follow the pattern from rapidsai/cugraph#3638

Required for 23.06 because python/cuspatial/pyproject.py does not exist thus breaking the script. This means any hotfixes to this version will have issues during release.

Also updates a version in cpp/doxygen/Doxyfile which was outdated.

Skipped CI since this script is not tested by CI.

@raydouglass raydouglass added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 7, 2023
@raydouglass raydouglass self-assigned this Jun 7, 2023
@raydouglass raydouglass requested review from a team as code owners June 7, 2023 17:07
@raydouglass raydouglass requested review from trxcllnt and isVoid and removed request for a team June 7, 2023 17:07
@github-actions github-actions bot added ci libcuspatial Relates to the cuSpatial C++ library labels Jun 7, 2023
@raydouglass raydouglass merged commit 34dc2a3 into rapidsai:branch-23.06 Jun 7, 2023
@raydouglass raydouglass deleted the fix-update-version branch June 7, 2023 17:27
@raydouglass raydouglass mentioned this pull request Jun 7, 2023
@bdice
Copy link
Contributor

bdice commented Jun 7, 2023

I was unable to review this before it was merged (20 minutes) but these changes will conflict with related fixes in https://github.com/rapidsai/cuspatial/pull/1175/files#diff-8a0188e09c831b0e6ca8c1c51ab640efd1e519b1d7f94ab6251c9f0b90a82304

@raydouglass
Copy link
Member Author

these changes will conflict with related fixes

I'll open a PR to resolve the conflicts in branch-23.08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

3 participants