Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cuSpatial pip packages #1148

Merged
merged 54 commits into from
Jun 2, 2023
Merged

cuSpatial pip packages #1148

merged 54 commits into from
Jun 2, 2023

Conversation

trxcllnt
Copy link
Contributor

Description

Initial draft PR to build statically linked cuspatial wheels.

Closes #869.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@trxcllnt trxcllnt requested review from a team as code owners May 22, 2023 18:08
@trxcllnt trxcllnt requested review from vyasr and isVoid May 22, 2023 18:08
@github-actions github-actions bot added ci cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library Python Related to Python code labels May 22, 2023
@trxcllnt trxcllnt added 2 - In Progress Currenty a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed cmake Related to CMake code or build configuration Python Related to Python code libcuspatial Relates to the cuSpatial C++ library ci labels May 22, 2023
@isVoid isVoid mentioned this pull request Jun 1, 2023
Closed
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

vyasr
vyasr reviewed Jun 1, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the flake8 configuration got lost.

There are a couple of things worth fixing here, but if you decide that this really has to get in ASAP I will leave these as comments without requesting changes so you can move forward and address later. I don't think anything is a strict blocker, the flake8 issue is the biggest one I see.

python/cuspatial/cuspatial/utils/join_utils.py Show resolved Hide resolved
dependencies.yaml Show resolved Hide resolved
python/cuspatial/CMakeLists.txt Outdated Show resolved Hide resolved
ajschmidt8
ajschmidt8 previously requested changes Jun 1, 2023
View reviewed changes
dependencies.yaml Show resolved Hide resolved
harrism
harrism approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readme instructions looks good!

jarmak-nv
jarmak-nv reviewed Jun 2, 2023
View reviewed changes
Copy link
Contributor

@jarmak-nv jarmak-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! Recommend making the suggestions so 3.11+ users don't try to install, but the readme updates are super thorough and clear. Love to see it!

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@trxcllnt @jarmak-nv
Apply suggestions from code review
f3bf3eb 
Co-authored-by: Ben Jarmak <104460670+jarmak-nv@users.noreply.github.com>
@trxcllnt
Copy link
Contributor Author

trxcllnt commented Jun 2, 2023

/merge

@trxcllnt trxcllnt dismissed ajschmidt8’s stale review June 2, 2023 01:33

Addressed comments

@rapids-bot rapids-bot bot merged commit 4b76c44 into rapidsai:branch-23.06 Jun 2, 2023
@trxcllnt trxcllnt deleted the fea/pip-packaging branch June 2, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@jarmak-nv jarmak-nv jarmak-nv left review comments

@harrism harrism harrism approved these changes

@raydouglass raydouglass raydouglass approved these changes

@bdice bdice bdice approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cuspatial-python-codeowners

@thomcom thomcom Awaiting requested review from thomcom

@ajschmidt8 ajschmidt8 Awaiting requested review from ajschmidt8

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team ci cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change Python Related to Python code
Projects
cuSpatial
Status: Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Use pip to install cuspatial
9 participants
@trxcllnt @harrism @thomcom @vyasr @raydouglass @bdice @ajschmidt8 @jarmak-nv @isVoid