Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clang-format to 15.0.7 #1072

Merged
merged 4 commits into from
Apr 19, 2023
Merged

Update clang-format to 15.0.7 #1072

merged 4 commits into from
Apr 19, 2023

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Apr 13, 2023 •
edited by harrism
Loading

This PR updates the clang-format version used by pre-commit. Fixes #1078.

@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 13, 2023
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Apr 13, 2023
@bdice bdice changed the title Update clang-format Update clang-format to 16.0.1. Apr 13, 2023
@bdice bdice marked this pull request as ready for review April 14, 2023 19:14
@bdice bdice requested a review from a team as a code owner April 14, 2023 19:14
@bdice bdice requested review from harrism and isVoid April 14, 2023 19:14
@bdice
Copy link
Contributor Author

bdice commented Apr 14, 2023

@harrism I think this just needs reviews, then should be good to merge. (Merging sooner means less likelihood of conflicts.)

@bdice bdice self-assigned this Apr 14, 2023
@harrism harrism self-assigned this Apr 18, 2023
@harrism harrism mentioned this pull request Apr 18, 2023
Closed
@harrism harrism changed the title Update clang-format to 16.0.1. Update clang-format to 15.0.7. Apr 18, 2023
@harrism harrism changed the title Update clang-format to 15.0.7. Update clang-format to 15.0.7 Apr 18, 2023
@harrism
Copy link
Member

harrism commented Apr 18, 2023

Updated to use clang-format 15.0.7 which doesn't have the operator* / brace initialization issue discovered in 16.0.1. We should follow up after 16.0.x is released with a fix.

@harrism harrism mentioned this pull request Apr 18, 2023
Merged
@harrism harrism requested review from trxcllnt, cwharris and isVoid and removed request for isVoid April 18, 2023 07:43
bdice
bdice commented Apr 19, 2023
View reviewed changes
Copy link
Contributor Author

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving changes made by @harrism (cannot approve my own PR though).

harrism
harrism approved these changes Apr 19, 2023
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving changes made by @bdice. :)

@harrism
Copy link
Member

harrism commented Apr 19, 2023

/merge

@rapids-bot rapids-bot bot merged commit 8f49daa into rapidsai:branch-23.06 Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid left review comments

@thomcom thomcom thomcom approved these changes

@harrism harrism harrism approved these changes

@trxcllnt trxcllnt Awaiting requested review from trxcllnt

@cwharris cwharris Awaiting requested review from cwharris

Assignees

@harrism harrism

@bdice bdice

Labels
improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA]: Update clang-format to a recent version
4 participants
@bdice @harrism @thomcom @isVoid