Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fix: point-in-multipolygon reduction using the wrong key-compare functor #1043

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Bug Fix: point-in-multipolygon reduction using the wrong key-compare functor #1043

merged 1 commit into from
Apr 7, 2023

Conversation

isVoid
Copy link
Contributor

@isVoid isVoid commented Apr 6, 2023

Description

This PR fixes #1042 . In point_polygon_intersects, the key comparator incorrectly uses the binary operator that's used for values.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@isVoid isVoid requested a review from a team as a code owner April 6, 2023 23:06
@isVoid isVoid requested review from trxcllnt and harrism April 6, 2023 23:06
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Apr 6, 2023
@isVoid isVoid added bug Something isn't working non-breaking Non-breaking change labels Apr 6, 2023
@thomcom
Copy link
Contributor

thomcom commented Apr 7, 2023

/merge

@rapids-bot rapids-bot bot merged commit 034bbb9 into rapidsai:branch-23.04 Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trxcllnt trxcllnt trxcllnt approved these changes

@thomcom thomcom thomcom approved these changes

@harrism harrism Awaiting requested review from harrism harrism is a code owner automatically assigned from rapidsai/cuspatial-cpp-codeowners

Assignees
No one assigned
Labels
bug Something isn't working libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: point-polygon distance generate wrong result
3 participants
@isVoid @thomcom @trxcllnt