Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor spatial join tests #1019

Merged
merged 9 commits into from
Apr 5, 2023
Merged

Refactor spatial join tests #1019

merged 9 commits into from
Apr 5, 2023

Conversation

harrism
Copy link
Member

@harrism harrism commented Mar 29, 2023

Description

Closes #1006
Closes #1007

I realized that the join_quadtree_and_bounding_boxes() tests are redundant to the quadtree_point_in_polygon tests and quadtree_point_to_nearest_linestring tests since the "small" test is duplicated in those. So I eliminated that test and added expectations for join_quadtree_and_bounding_boxes in those tests.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Mar 29, 2023
@harrism harrism added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Mar 29, 2023
@trxcllnt
Copy link
Contributor

trxcllnt commented Mar 29, 2023 •
edited
Loading

I think the reason these were split out was so join_quadtree_and_bounding_boxes() tests could be compiled independently of the other spatial join routines, to cut down on compile times and/or if there's a compile error in quadtree PIP/P2NS.

But if we're not expecting to need to change the implementations of these routines much anymore, I'm OK merging these tests.

@github-actions github-actions bot added cmake Related to CMake code or build configuration libcuspatial Relates to the cuSpatial C++ library labels Apr 4, 2023
@harrism harrism marked this pull request as ready for review April 4, 2023 05:34
@harrism harrism requested review from a team as code owners April 4, 2023 05:34
@harrism harrism requested review from isVoid and trxcllnt April 4, 2023 05:34
robertmaynard
robertmaynard approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving CMake changes

isVoid
isVoid reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@isVoid isVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that tests are incremental checkpoints for developers to validate the correctness of the function. It would be nice to leave some comments in the test block for bounding_boxes API and mention it's a checkpoint for this API.

cpp/tests/experimental/join/join_quadtree_and_bounding_boxes_test.cu Show resolved Hide resolved
@harrism
Copy link
Member Author

harrism commented Apr 5, 2023

/merge

@rapids-bot rapids-bot bot merged commit ccf526a into rapidsai:branch-23.04 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isVoid isVoid isVoid left review comments

@trxcllnt trxcllnt trxcllnt approved these changes

@robertmaynard robertmaynard robertmaynard approved these changes

Assignees
No one assigned
Labels
cmake Related to CMake code or build configuration improvement Improvement / enhancement to an existing function libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
cuSpatial
Status: Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port join_quadtree_and_bounding_boxes tests to header-only API Port point_quadtree tests to header-only API
4 participants
@harrism @trxcllnt @robertmaynard @isVoid