Dependency differences between Conda & wheel

[jakirkham]

In the Conda recipe, these dependencies are listed

cusignal/conda/recipes/cusignal/meta.yaml

Lines 29 to 34 in 09915e5

	run:
	- cupy >=12.0.0
	- numba >=0.49.0
	- numpy >=1.19,<1.24
	- python
	- scipy >=1.6.0

However the wheel only lists one of those

cusignal/python/setup.py

Line 18 in 09915e5

INSTALL_REQUIRES = ["numba"]

Should these be synced to have the same lists?

[jakirkham]

cc @vyasr (for vis)

[awthomp]

The Python wheel should include the dependencies listed in the conda meta.yaml recipe. cupy, numpy, scipy, and numba are all hard dependencies for cuSignal.

[vyasr]

Ideally they should be synced, but in practice until we start promising that our packages are pip installable it doesn't really matter. Pretty much all of RAPIDS had the wrong dependencies listed in setup.py/setup.cfg/pyproject.toml until we actually started making wheels. It would be nice to fix, but it's hard to synchronize without some process to actually build and test using those dependencies (unless you update to producing pyproject.toml dependencies using rapids-dependency-file-generator, which would also require transitioning this package to being pyproject.toml based).

[jakirkham]

cc @vyasr (for vis)

[awthomp]

The Python wheel should include the dependencies listed in the conda meta.yaml recipe. cupy, numpy, scipy, and numba are all hard dependencies for cuSignal.

[vyasr]

Ideally they should be synced, but in practice until we start promising that our packages are pip installable it doesn't really matter. Pretty much all of RAPIDS had the wrong dependencies listed in setup.py/setup.cfg/pyproject.toml until we actually started making wheels. It would be nice to fix, but it's hard to synchronize without some process to actually build and test using those dependencies (unless you update to producing pyproject.toml dependencies using rapids-dependency-file-generator, which would also require transitioning this package to being pyproject.toml based).